jupiterbroadcasting.com icon indicating copy to clipboard operation
jupiterbroadcasting.com copied to clipboard

footer - align links in rows, less vertical space

Open GL513 opened this issue 3 years ago • 6 comments

Screenshot_20220808-174411_Chrome.jpg

Align text to be next to each other (at least in mobile) so it doesn't take a bunch of space up.

First issue! :)

GL513 avatar Aug 08 '22 21:08 GL513

First Issue! Woot Woot! 🎉

If I understand correctly, @GL513 your suggestion worded differently:

  • Currently the footer items are center-aligned, one per line and thus take up lots of vertical space on mobile-sized screens. Consider grouping multiple items on a single line to save vertical space.

...correct?

gerbrent avatar Aug 09 '22 14:08 gerbrent

First Issue! Woot Woot! 🎉

If I understand correctly, @GL513 your suggestion worded differently:

  • Currently the footer items are center-aligned, one per line and thus take up lots of vertical space on mobile-sized screens. Consider grouping multiple items on a single line to save vertical space.

...correct?

Yes correct, sorry for not taking the time to write it out better :(

GL513 avatar Aug 10 '22 23:08 GL513

All good!

gerbrent avatar Aug 11 '22 03:08 gerbrent

Maybe alphabetical too?

ozcoder avatar Aug 25 '22 11:08 ozcoder

Like this?

index 55c036c..891ef4a 100644
--- a/themes/jb/assets/css/components/footer.sass
+++ b/themes/jb/assets/css/components/footer.sass
@@ -7,3 +7,9 @@
   .title
     color: $white
     margin-bottom: 0.5rem
+  @include until($tablet)
+    ul
+      display: flex
+      flex-wrap: wrap
+      li
+        flex: 1 1 32%```

ozcoder avatar Sep 30 '22 12:09 ozcoder

This almost works for sorting the links

index 2426af7..b766c3b 100644
--- a/themes/jb/layouts/partials/footer.html
+++ b/themes/jb/layouts/partials/footer.html
@@ -10,7 +10,7 @@
           <div class="column has-text-centered-mobile">
             <h6 class="title is-6">{{ .Site.Params.footer.left.headline }}</h6>
             <ul>
-              {{ range where site.RegularPages "Section" "community" }}
+              {{ range (where site.RegularPages "Section" "community").ByTitle }}
                   {{ $link := "" }}
                   {{ if .Params.direct_link }}
                     {{ $link = .Params.direct_link }}```

ozcoder avatar Sep 30 '22 14:09 ozcoder