Symbolics.jl icon indicating copy to clipboard operation
Symbolics.jl copied to clipboard

Handle tuples in build_function.jl

Open 5hv5hvnk opened this issue 8 months ago • 5 comments

Solves #1438 Added a work around to treat tuples as array and then return a tuple by converting it to a list.

ToDo:

  • [ ] Add tests

5hv5hvnk avatar Mar 03 '25 06:03 5hv5hvnk

This would allocate though?

ChrisRackauckas avatar Mar 03 '25 07:03 ChrisRackauckas

I think so, I can probably write some tests to verify? I tried it on the example in issue and it was working, not sure if it will generalize.

5hv5hvnk avatar Mar 03 '25 18:03 5hv5hvnk

Yes write some tests that check if the tuple route is non-allocating on simple functions. I don't think it would pass.

ChrisRackauckas avatar Mar 03 '25 18:03 ChrisRackauckas

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 7.70%. Comparing base (eced900) to head (b1f2e5d). Report is 164 commits behind head on master.

Files with missing lines Patch % Lines
src/build_function.jl 0.00% 29 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1462      +/-   ##
=========================================
- Coverage    8.88%   7.70%   -1.18%     
=========================================
  Files          51      51              
  Lines        4876    4943      +67     
=========================================
- Hits          433     381      -52     
- Misses       4443    4562     +119     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Apr 01 '25 14:04 codecov-commenter

@AayushSabharwal how do this come into your changes to function building?

ChrisRackauckas avatar Apr 06 '25 15:04 ChrisRackauckas