Symbolics.jl icon indicating copy to clipboard operation
Symbolics.jl copied to clipboard

Added BasicSymbolic as input for function fed to derivative

Open kapple19 opened this issue 1 year ago • 4 comments

And fixed TypeError usage.

Should hopefully be enough to close #1085.

kapple19 avatar Sep 04 '24 15:09 kapple19

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.57%. Comparing base (ff30ebf) to head (a58baa0). Report is 28 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1257      +/-   ##
==========================================
- Coverage   80.58%   80.57%   -0.01%     
==========================================
  Files          51       51              
  Lines        5136     5144       +8     
==========================================
+ Hits         4139     4145       +6     
- Misses        997      999       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Sep 04 '24 15:09 codecov-commenter

Can this get tests?

ChrisRackauckas avatar Sep 08 '24 01:09 ChrisRackauckas

I should have time this weekend to look this through. I was confused as to how to write tests for this change.

kapple19 avatar Sep 19 '24 15:09 kapple19

Bump?

ChrisRackauckas avatar Oct 06 '24 03:10 ChrisRackauckas

Is this test sufficient @ChrisRackauckas ? I don't fully understand the BasicSymbolic infrastructure. Sorry I forgot about this.

kapple19 avatar Jun 18 '25 14:06 kapple19