Symbolics.jl
Symbolics.jl copied to clipboard
Simplify sqrt((A/B)^2) => A/B
Now the example from
https://discourse.julialang.org/t/comparing-symbolics-jl-with-mathematica/118656
simplifies to
julia> symbolic_solve(-279//16 + x^2, x)
2-element Vector{SymbolicUtils.BasicSymbolic{Real}}:
(3//4)*√(31//1)
(-3//4)*√(31//1)
Why 31//1 is not simplified to 31 although we have the code for it? -- I have no idea.
I only know that I can make it simplify to 31 if I delete the last expand here: https://github.com/JuliaSymbolics/Symbolics.jl/blob/f4d53fe9c9629e2b1117f8835ebe45c3dc81bf15/src/solver/postprocess.jl#L108
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.90%. Comparing base (
47cfd60) to head (95e61a2). Report is 36 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #1243 +/- ##
===========================================
+ Coverage 8.30% 79.90% +71.59%
===========================================
Files 46 46
Lines 4549 4653 +104
===========================================
+ Hits 378 3718 +3340
+ Misses 4171 935 -3236
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.