Metatheory.jl
Metatheory.jl copied to clipboard
ale/3.0 terminterface vecexpr
This restores TermInterface for VecExpr since we use a custom type and should avoid dispatch as well.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.
Project coverage is 82.44%. Comparing base (
f687b00) to head (af878be).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ext/Plotting.jl | 0.00% | 4 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## ale/3.0 #270 +/- ##
===========================================
+ Coverage 82.28% 82.44% +0.15%
===========================================
Files 19 19
Lines 1547 1544 -3
===========================================
Hits 1273 1273
+ Misses 274 271 -3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Benchmark Results
| egg-sym | egg-cust | MT@af878be1d54... | MT@f687b005cd3... | egg-sym/MT@af8... | egg-cust/MT@af... | MT@f687b005cd3... | |
|---|---|---|---|---|---|---|---|
| egraph_addexpr | 1.42 ms | 9.12 ms | 5.11 ms | 0.156 | 0.56 | ||
| basic_maths_simpl2 | 12.7 ms | 5.2 ms | 21.9 ms | 22.8 ms | 0.58 | 0.237 | 1.04 |
| prop_logic_freges_theorem | 2.53 ms | 1.55 ms | 2.32 ms | 2.28 ms | 1.09 | 0.67 | 0.983 |
| calc_logic_demorgan | 60.6 μs | 34.5 μs | 84.8 μs | 78.7 μs | 0.714 | 0.407 | 0.929 |
| calc_logic_freges_theorem | 22.1 ms | 12.1 ms | 42.6 ms | 42.1 ms | 0.52 | 0.285 | 0.988 |
| basic_maths_simpl1 | 6.11 ms | 2.88 ms | 4.52 ms | 4.46 ms | 1.35 | 0.637 | 0.986 |
| egraph_constructor | 0.0861 μs | 0.1 μs | 0.0984 μs | 0.857 | 0.98 | ||
| prop_logic_prove1 | 35.6 ms | 14.1 ms | 39.1 ms | 40.3 ms | 0.911 | 0.361 | 1.03 |
| prop_logic_demorgan | 80 μs | 45.1 μs | 98.8 μs | 94.6 μs | 0.81 | 0.457 | 0.957 |
| while_superinterpreter_while_10 | 18.4 ms | 18.4 ms | 0.999 | ||||
| prop_logic_rewrite | 113 μs | 113 μs | 1 | ||||
| time_to_load | 121 ms | 123 ms | 1.02 |
Benchmark Plots
A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).
There might be a case of runtime dispatch left somewhere. Needs JET investigation