TimeSeries.jl icon indicating copy to clipboard operation
TimeSeries.jl copied to clipboard

`Base.view` support

Open iblislin opened this issue 6 years ago • 5 comments

@view ta[1:42]

to avoid allocation

iblislin avatar Jun 18 '19 08:06 iblislin

Maybe we need a new type for viewed TimeArray.

iblislin avatar Jul 05 '19 03:07 iblislin

Hi, is there an ETA on this functionality? We have integrated TimeSeries in our package, but when slicing data, there is too much memory allocation with respect to DataFrames. We would like to keep TimeArrays, but the performance hit is significant.

jd-lara avatar Jul 25 '19 16:07 jd-lara

Hi @jd-lara , no ETA at this moment. I can mark this issue as high priority in my mind. I still need to do some surveys about the implementation details of @view.

iblislin avatar Jul 26 '19 05:07 iblislin

Thanks, we will stick with TimeArrays for now and hopefully won't be too much of a bottleneck.

jd-lara avatar Jul 26 '19 20:07 jd-lara

I wrote some study notes here:

  • [ ] Design doc of Julia's native SubArray is here: https://docs.julialang.org/en/v1/devdocs/subarrays/index.html
  • [ ] We might need a new data type SubTimeArray, in order to provide index translation on the top of getindex syntax.
    • e.g. SubTimeArray[1:10, :col] won't copy.

iblislin avatar Aug 11 '19 11:08 iblislin