Statistics.jl icon indicating copy to clipboard operation
Statistics.jl copied to clipboard

Work without stdlib `SparseArrays.jl`

Open inkydragon opened this issue 1 year ago • 3 comments

People could build a julia without SparseArrays.jl by setting the flag USE_GPL_LIBS=0.

xref: https://github.com/JuliaLang/julia/issues/53211

inkydragon avatar Feb 06 '24 18:02 inkydragon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (68869af) 97.01% compared to head (b63f738) 96.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   97.01%   96.99%   -0.02%     
==========================================
  Files           2        2              
  Lines         435      433       -2     
==========================================
- Hits          422      420       -2     
  Misses         13       13              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 06 '24 19:02 codecov-commenter

Is there anything else to do on this PR? Thanks

gitboy16 avatar Apr 23 '24 14:04 gitboy16

@gitboy16

Is there anything else to do on this PR?

There is no explicit use of functions from GPL solver modules (umfpack, cholmod, spqr) in ext/SparseArraysExt.jl.

Maybe we don't need this pr. Waiting for #163.

See also: JuliaLang/julia#54240

inkydragon avatar Apr 25 '24 02:04 inkydragon