Distributions.jl icon indicating copy to clipboard operation
Distributions.jl copied to clipboard

formatter with Runic

Open mmikhasenko opened this issue 5 months ago • 6 comments

Formatting cleanup using JuliaFormatter.format(".") to ensure consistent code style across the package. This reduces noisy diffs in future changes and improves readability. No functional changes.

Closes #1401

Modifications

  • [x] add .formating with scripts
  • [x] modified README.md. Added formatting rules
  • [x] added .git-blame-ignore-revs to
  • [x] applied formatting

Tests

  • [x] are passing

mmikhasenko avatar Jun 23 '25 14:06 mmikhasenko

I'd actually prefer Runic, it seems to work fine in StatsFuns and PDMats and I've been bitten by JuliaFormatter 2 problems a few times. GLM uses JuliaFormatter though, so there is no agreed on standard in JuliaStats yet.

devmotion avatar Jun 23 '25 14:06 devmotion

I'd actually prefer Runic, it seems to work fine in StatsFuns and PDMats and I've been bitten by JuliaFormatter 2 problems a few times. GLM uses JuliaFormatter though, so there is no agreed on standard in JuliaStats yet.

completely fine with me, I do not have preference

mmikhasenko avatar Jun 23 '25 15:06 mmikhasenko

Codecov Report

Attention: Patch coverage is 83.28518% with 405 lines in your changes missing coverage. Please review.

Project coverage is 86.21%. Comparing base (abb151c) to head (3bede98).

Files with missing lines Patch % Lines
src/univariate/continuous/kolmogorov.jl 36.36% 28 Missing :warning:
src/samplers/obsoleted.jl 0.00% 20 Missing :warning:
src/multivariate/mvnormal.jl 74.28% 18 Missing :warning:
src/univariate/continuous/chernoff.jl 35.71% 18 Missing :warning:
src/multivariate/dirichlet.jl 69.81% 16 Missing :warning:
src/mixtures/mixturemodel.jl 76.19% 15 Missing :warning:
src/univariate/continuous/triweight.jl 48.14% 14 Missing :warning:
src/multivariate/mvtdist.jl 66.66% 12 Missing :warning:
src/univariate/continuous/epanechnikov.jl 45.45% 12 Missing :warning:
src/univariate/continuous/skewnormal.jl 62.50% 12 Missing :warning:
... and 81 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1987      +/-   ##
==========================================
- Coverage   86.28%   86.21%   -0.08%     
==========================================
  Files         146      146              
  Lines        8787     8798      +11     
==========================================
+ Hits         7582     7585       +3     
- Misses       1205     1213       +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 23 '25 15:06 codecov-commenter

The work is complete. Tests are passing. Could you please review?

mmikhasenko avatar Jun 25 '25 09:06 mmikhasenko

ping @st-- , the author of original issue #1401, for an opinion.

mmikhasenko avatar Jun 25 '25 09:06 mmikhasenko

Maybe let's merge https://github.com/JuliaStats/Distributions.jl/pull/1905 before changing the formatting.

devmotion avatar Jun 25 '25 10:06 devmotion