JuliaVariables.jl

JuliaVariables.jl copied to clipboard

Incorrect handling of `setindex!` expressions

1

`x` should be global in both of these: ```julia julia> solve_from_local(:(x[] = 1)) :($(Expr(:scoped, (bounds = Var[@local x], freevars = Var[], bound_inits = Symbol[]), :((@local x)[] = 1)))) julia> solve_from_local(:(setindex!(x,...

MasonProtter

Add unique_id field to Var

4

Closes https://github.com/JuliaStaging/JuliaVariables.jl/issues/28 For demonstration, I temporarily added the `@show` line here: ```julia function local_var_to_var(var::LocalVar)::Var unique_id = Symbol(var.sym, "_", id[var.sym]) @show unique_id # Remove after demo Var(var.sym, unique_id, var.is_mutable[], var.is_shared[], false)...

cscherrer

Can `Var` have an `id` field?

8

For code rewriting, it can be really useful to have more to distinguish a variable than just its name. For example, we might want to do things like "rename all...

cscherrer

```julia ex = :(let x = y; x + y end) solve_from_local!(ex; custom_locals = [:y]) ```

thautwarm

To allow users to define their own scoping rules with builtin rules.

thautwarm

https://github.com/thautwarm/JuliaVariables.jl/blob/b66db8e1f1efc84406b073ad2a8c03efe34c6b62/src/JuliaVariables.jl#L233 This is relevant to https://github.com/thautwarm/GeneralizedGenerated.jl/issues/44 . It seems that at least `Expr` and `Symbol` can have scopes, while a literal, or `QuoteNode` cannot. I'll update the code once I...

thautwarm

Macro arguments are treated as globals

3

It seems that macro arguments are treated as globals (see `@global x`) ```julia julia> solve(:(macro f(x) end)) :(macro (@global f)(@global x) #= REPL[12]:1 =# end) ``` Compare this to a...

tkf

"Type aliases" like `X{T} = Y{T, S}` are not handled

2

It seems that "type aliases" are not handled correctly at the moment: ```julia julia> solve(:(X{T} = Y{T, S})) :((@global X){@global T} = (@global Y){@global T, @global S}) ``` I suppose...

tkf

Fields of struct are treated as globals

2

Hi, thanks for a super useful package. Unfortunately, I think I find a bug ```julia julia> solve(:(struct S x end)) :(struct @global S #= REPL[11]:2 =# @global x end) ```...

tkf

```julia julia> solve_from_local(quote x = :(x + 1) end) quote #= REPL[6]:2 =# @x = $(Expr(:quote, :((@global +)(@x, 1)))) end ``` `:(x+1)` shouldn't be analysed. The things can be analysed...

thautwarm