NLPModelsJuMP.jl icon indicating copy to clipboard operation
NLPModelsJuMP.jl copied to clipboard

Combine this package with SparseMatricesCOO

Open tmigot opened this issue 3 years ago • 3 comments
trafficstars

We could probably simplify a few things using https://github.com/JuliaSmoothOptimizers/SparseMatricesCOO.jl

  • [ ] SparseMatrixCOO instead of COO https://github.com/JuliaSmoothOptimizers/NLPModelsJuMP.jl/blob/c05a30f503d990823407159492fd40b27fc2ee36/src/utils.jl#L28
  • [ ] Move coo_sym_dot https://github.com/JuliaSmoothOptimizers/NLPModelsJuMP.jl/blob/c05a30f503d990823407159492fd40b27fc2ee36/src/utils.jl#L74 to https://github.com/JuliaSmoothOptimizers/SparseMatricesCOO.jl/blob/main/src/coo_linalg.jl
  • [ ] Move coo_sym_add_mul! https://github.com/JuliaSmoothOptimizers/NLPModelsJuMP.jl/blob/c05a30f503d990823407159492fd40b27fc2ee36/src/utils.jl#L74 to https://github.com/JuliaSmoothOptimizers/SparseMatricesCOO.jl/blob/main/src/coo_linalg.jl

tmigot avatar May 06 '22 19:05 tmigot

It's an excellent idea @tmigot, I didn't find the time to look at SparseMatricesCOO.jl but we should use it as a dependency of NLPModelsJuMP.jl.

amontoison avatar May 06 '22 19:05 amontoison

I think it should be a dependency of NLPModels to begin with.

dpo avatar May 06 '22 20:05 dpo

Agreed, this is connected to https://github.com/JuliaSmoothOptimizers/NLPModels.jl/issues/389

tmigot avatar May 06 '22 20:05 tmigot