Change Real to Number

[geoffroyleconte]

[codecov[bot]]

Codecov Report

Base: 88.91% // Head: 88.91% // No change to project coverage :thumbsup:

Coverage data is based on head (2d747e8) compared to base (51eec8d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files           1        1           
  Lines         388      388           
=======================================
  Hits          345      345           
  Misses         43       43           

Impacted Files	Coverage Δ
src/LimitedLDLFactorizations.jl	88.91% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[dpo]

Could we just leave Tf as an (unspecified) parameter?

[geoffroyleconte]

Probably, the only issue would be that if there is an error because of Tf, it would be more difficult to debug (for example I don't know if this would work directly for complex numbers). If you think that it's fine, I can open a PR.

[dpo]

As you pointed out earlier, we need to use conj in appropriate places to ensure correctness, but I think I would leave Tf free.