General icon indicating copy to clipboard operation
General copied to clipboard

Fix DiskArrays compat

Open meggart opened this issue 1 year ago • 1 comments

Update compat instead of yanking release, replaces #102850

meggart avatar Apr 04 '24 10:04 meggart

https://github.com/JuliaRegistries/General/blob/00dfc2edb0c9ac583ef81d47954445adc1101e54/D/DiskArrays/Compat.toml#L7 has to change to something like

["0.3"]

otherwise you have conflicting specifications.

giordano avatar Apr 04 '24 10:04 giordano

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

github-actions[bot] avatar May 04 '24 12:05 github-actions[bot]

What is happening here... the yank was such an obvious quick fix to just merge, and now we have chaos instead:

https://github.com/yeesian/ArchGDAL.jl/actions/runs/8969588301/job/24631262216?pr=423

(is the idea that instead we just cut out 0.4.0 completely from any julia compatability? isn't that just identical to a yank, but harder to understand?)

rafaqz avatar May 06 '24 13:05 rafaqz

is the idea that instead we just cut out 0.4.0 completely from any julia compatability?

No.

giordano avatar May 06 '24 14:05 giordano

But isn't that what your change does? wont there be no version of julia where 0.4.0 can be added?

If so, what version will it work on?

rafaqz avatar May 06 '24 14:05 rafaqz

But isn't that what your change does?

No.

wont there be no version of julia where 0.4.0 can be added?

Julia v1.9+

giordano avatar May 06 '24 14:05 giordano

Ahh right there always needs to be a version change in two places, not just the one, or there is a conflict.

The example link goes to the file without the current PR changes so skimming it looks like you meant "instead of", but I guess thats just github UI not letting you link the PR file.

rafaqz avatar May 06 '24 14:05 rafaqz

Sorry to all for losing attention on this one. I hope this will fix it now.

meggart avatar May 06 '24 14:05 meggart