CompatHelper.jl icon indicating copy to clipboard operation
CompatHelper.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaRegistries

check "extras" not just "deps" ?

Open bjarthur opened this issue 5 years ago • 4 comments

would it make sense to check everything that's in "compat", not just the subset that's also listed in "deps"? the stuff in "extras" seems not to be checked. see https://github.com/GiovineItalia/Compose.jl/issues/374

bjarthur avatar Dec 21 '19 16:12 bjarthur

Hello, is there anything I can bump/help with to get this implemented?

exaexa avatar May 11 '23 08:05 exaexa

I think with #458, a single-line change to loop over ["deps", "weakdeps", "extras"] instead of just ["deps", "weakdeps"] would resolve this issue.

sethaxen avatar Oct 31 '23 09:10 sethaxen

yeah looks like that's it. I'll try to open another PR when #458 gets merged. (Not sure if adding more stuff to that PR would be good)

exaexa avatar Oct 31 '23 10:10 exaexa

I agree. Also, for [extras], people may want the ability to opt out of updating that particular section's compats (similar to how they currently need to opt in to test/Project.toml being updated)

sethaxen avatar Oct 31 '23 12:10 sethaxen