Fix failure setting optimize option (#480)

[dpinol]

trafficstars

Fixes #480

[codecov[bot]]

Codecov Report

Base: 87.34% // Head: 87.37% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (1c43748) compared to base (b95e524). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   87.34%   87.37%   +0.02%     
==========================================
  Files          39       39              
  Lines        2316     2320       +4     
==========================================
+ Hits         2023     2027       +4     
  Misses        293      293              

Impacted Files	Coverage Δ
src/julia/tests/test_juliaoptions.py	100.00% <ø> (ø)
src/julia/options.py	96.19% <100.00%> (ø)
src/julia/tests/test_options.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[MilesCranmer]

@mkitti do you think you could merge this? (You have merge access, right?)

[mkitti]

We would need to get these tests passing

[mkitti]

@MilesCranmer Clone the branch, get the tests to pass, and submit a new PR pinging me. Then I will merge it.

[dpinol]

logs have expired. Can sb rerun the tests?

[mkitti]

Considering rebasing

[dpinol]

@mkitti done

[mkitti]

Hmm, that did not seem to fix testing.

[MilesCranmer]

It seems unrelated to this PR - the issue seems to be because the CI is trying to download a pip package from an HTTP URL instead of HTTPS, and urllib no longer allows non-SSL requests:

      Downloading http://pypi.python.org/packages/source/d/distribute/distribute-0.6.27.tar.gz

I think that's why the Python 2.7 version works - since the old urllib hasn't deprecated non-SSL.

[MilesCranmer]

FYI @dpinol once #508 is merged this should work

[dpinol]

@MilesCranmer rebased. thanks

[MilesCranmer]

@mkitti any idea how to change the actions for “Required statuses must pass before merging”? It seems like they are for a different CI naming scheme maybe.

[mkitti]

any idea how to change the actions for “Required statuses must pass before merging”? It seems like they are for a different CI naming scheme maybe.

Let me take a look at the branch protection rules.

[mkitti]

Status checks should be functional now

[MilesCranmer]

Could this one be merged?

[MilesCranmer]

Awesome! 🚀