Changed Orientation to Permute

[Jonas-a-Zimmermann]

Removing the depcracted orientation in favour of permute in the cornerplot recipe. This fixes the ylims issue mentioned https://github.com/JuliaPlots/Plots.jl/issues/5007 and https://github.com/TuringLang/MCMCChains.jl/issues/426 .

[codecov-commenter]

Codecov Report

:x: Patch coverage is 0% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 26.46%. Comparing base (bb65b7c) to head (1c80878). :warning: Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
src/cornerplot.jl	0.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
- Coverage   26.52%   26.46%   -0.06%     
==========================================
  Files          20       20              
  Lines        1248     1247       -1     
==========================================
- Hits          331      330       -1     
  Misses        917      917              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[scheidan]

Having the corner plots working again would be quite important, especially for MCMC related work. Is there anything missing in this PR?

[Jonas-a-Zimmermann]

well, it fixes the errors JuliaPlots/Plots.jl#5007 (first note) and should also fix https://github.com/TuringLang/MCMCChains.jl/issues/426 (on my machine). In that sense it should be complete. There are other Issues with the cornerplot, but they originate at other places and are not adressed in here. See e.g. JuliaPlots/Plots.jl#5007 (second note) https://github.com/JuliaPlots/Plots.jl/issues/4949 , but they are due to bugs in Plots.jl directly.

[scheidan]

Thanks! It would be great to have it merged, even if it’s just a stop-gap solution. Corner plots have been broken for 10 months now…

I know everyone’s short on time for maintenance, but in this case, we already have a solution. Is there a maintainer we can ping?

[mkborregaard]

lgtm