openlibm icon indicating copy to clipboard operation
openlibm copied to clipboard

CMake Changes

Open theoparis opened this issue 1 year ago • 1 comments

  • Removing SHARED allows openlibm to be built statically depending on the value of BUILD_SHARED_LIBS
  • Using CMAKE_CURRENT_SOURCE_DIR allows openlibm to be built via FetchContent
  • I added the riscv64 architecture to openlibm's cmake build scripts

theoparis avatar Mar 15 '24 23:03 theoparis

Merge?

ViralBShah avatar Apr 03 '24 04:04 ViralBShah

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.02%. Comparing base (4b83beb) to head (a1fdd7c). Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   38.24%   39.02%   +0.78%     
==========================================
  Files         233      233              
  Lines        6139     6144       +5     
  Branches     1607     1607              
==========================================
+ Hits         2348     2398      +50     
+ Misses       3394     3393       -1     
+ Partials      397      353      -44     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 19 '24 20:06 codecov[bot]

Can you rebase to master? Is this ok to merge given the changes in #302? It looks like there is no conflict.

ViralBShah avatar Jun 19 '24 23:06 ViralBShah

Hello @theoparis , could you confirm that the current git version works for you with FetchContent?

Also, if you don't mind me asking, have you tried using package managers instead of FetchContent? I'm assuming you're using it to pull OpenLibm into your project

ViliusSutkus89 avatar Jun 25 '24 13:06 ViliusSutkus89