Infinities.jl
Infinities.jl copied to clipboard
fix ambiguities
Aqua is set to check ambiguities.
- Solves #36
Related changes:
- Some tests change from
NotANumbertoArgumentError#38 - Standalone
+∞now refers toRealInfinity(). Some+/-test results have changed accordingly, although not consistent. #39 - Support
(fld|cld|div)(∞, x)wherex<0 Aquatests are moved to the end of tests to make sure things work before fixing ambiguities.- Support infinite
Complex{float} + ∞ min|maxare set to follow Julia base convention, that is,min(x,y)=xandmax(x,y)=yifx==y. This impactsℵ₀and∞specifically. #41
Not to do:
- Aim at full coverage. Most coverage losses are caused by ambiguity fix and are checked by
Aqua.
Codecov Report
Patch coverage: 86.72% and project coverage change: -7.81 :warning:
Comparison is base (
489b68b) 99.17% compared to head (95e4dbb) 91.37%.
Additional details and impacted files
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 99.17% 91.37% -7.81%
==========================================
Files 2 6 +4
Lines 363 197 -166
==========================================
- Hits 360 180 -180
- Misses 3 17 +14
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/cardinality.jl | 88.09% <0.00%> (-10.50%) |
:arrow_down: |
| src/ambiguities.jl | 52.63% <52.63%> (ø) |
|
| src/Infinities.jl | 96.07% <66.66%> (-3.47%) |
:arrow_down: |
| src/interface.jl | 87.50% <87.50%> (ø) |
|
| src/algebra.jl | 100.00% <100.00%> (ø) |
|
| src/compare.jl | 100.00% <100.00%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.