Infinities.jl icon indicating copy to clipboard operation
Infinities.jl copied to clipboard

Use distinct types for RealInfinity

Open putianyi889 opened this issue 2 years ago • 2 comments

This change will make it easier to handle ambiguities and conflicts. Old interface is reserved, except for x.signbit fully replaced by signbit(x).

  • #5

putianyi889 avatar Jun 06 '23 20:06 putianyi889

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0972ead) 99.14% compared to head (cb8e5d9) 99.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   99.14%   99.15%           
=======================================
  Files           2        2           
  Lines         350      353    +3     
=======================================
+ Hits          347      350    +3     
  Misses          3        3           
Impacted Files Coverage Δ
src/Infinities.jl 99.55% <100.00%> (+<0.01%) :arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 06 '23 20:06 codecov[bot]

Wouldn't this be a breaking change? Why not just introduce new types, and keep RealInfinity as is?

nsajko avatar Aug 31 '24 16:08 nsajko