Infinities.jl icon indicating copy to clipboard operation
Infinities.jl copied to clipboard

Is there a reason to skip ambiguity test in Aqua?

Open putianyi889 opened this issue 2 years ago • 1 comments

I have another project depending on Infinities.jl and Aqua reports over 100 ambiguities. For example

julia> ℵ₀==big(1)
ERROR: MethodError: ==(::InfiniteCardinal{0}, ::BigInt) is ambiguous.

Candidates:
  ==(i::Integer, x::BigInt)
    @ Base.GMP gmp.jl:698
  ==(::InfiniteCardinal, y::Real)
    @ Infinities C:\Users\pty\.julia\packages\Infinities\Y1fpA\src\cardinality.jl:56

Possible fix, define
  ==(::InfiniteCardinal, ::BigInt)

Stacktrace:
 [1] top-level scope
   @ REPL[7]:1

putianyi889 avatar Jun 06 '23 10:06 putianyi889

Probably just needs someone to go through and fix all the ambiguities

dlfivefifty avatar Jun 06 '23 12:06 dlfivefifty