Combinatorics.jl icon indicating copy to clipboard operation
Combinatorics.jl copied to clipboard

Add `multiset_permutations` method that doesn't require length

Open oscardssmith opened this issue 1 year ago • 4 comments

in analogy to the same case for regular permuations

oscardssmith avatar Apr 30 '24 15:04 oscardssmith

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.41%. Comparing base (a303e88) to head (6afa6f0).

:exclamation: Current head 6afa6f0 differs from pull request most recent head 2813a19. Consider uploading reports for the commit 2813a19 to get more accurate results

Files Patch % Lines
src/permutations.jl 0.00% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   96.89%   96.41%   -0.48%     
==========================================
  Files           8        8              
  Lines         804      808       +4     
==========================================
  Hits          779      779              
- Misses         25       29       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 30 '24 15:04 codecov[bot]

Maybe add some tests or doctests

inkydragon avatar Apr 30 '24 21:04 inkydragon

test added.

oscardssmith avatar May 01 '24 02:05 oscardssmith

should this be merged?

oscardssmith avatar May 28 '24 17:05 oscardssmith