Combinatorics.jl icon indicating copy to clipboard operation
Combinatorics.jl copied to clipboard

Bugfix: include empty combination

Open Stivanification opened this issue 2 years ago • 1 comments

Closes Issues #86 and #123. Currently the output of combinations(a) does not include the empty combination, which is a bug. Also in the tests, we should have combinations([]) = [[]], i.e., an array that contains the empty set, not the empty set itself.

Stivanification avatar Dec 26 '22 12:12 Stivanification

Codecov Report

Base: 96.85% // Head: 96.85% // No change to project coverage :thumbsup:

Coverage data is based on head (7ceb259) compared to base (d1b633b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files           7        7           
  Lines         700      700           
=======================================
  Hits          678      678           
  Misses         22       22           
Impacted Files Coverage Δ
src/combinations.jl 85.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Dec 26 '22 12:12 codecov[bot]