Combinatorics.jl icon indicating copy to clipboard operation
Combinatorics.jl copied to clipboard

Reviving #84

Open mschauer opened this issue 3 years ago • 1 comments

The documentation for stirlings1 and stirlings2 indicates that they can use BigInts if provided with such as argument. However the existing functions specify n and k arguments to be Int. This patch allows support for BigInt integers without breaking type consistency of return types, and also provides for some memoization, since otherwise the functions, since they are recursive, can be slow when handling very large integers. (@wherrera10 in #84)

mschauer avatar Nov 11 '22 08:11 mschauer

Codecov Report

Base: 96.85% // Head: 96.89% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (55725ed) compared to base (d1b633b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   96.85%   96.89%   +0.03%     
==========================================
  Files           7        7              
  Lines         700      708       +8     
==========================================
+ Hits          678      686       +8     
  Misses         22       22              
Impacted Files Coverage Δ
src/numbers.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Nov 11 '22 08:11 codecov[bot]