Downloads.jl
Downloads.jl copied to clipboard
Allow per-request setting of options on the Curl easy_handle
This allows any of the more esoteric CURL options to be applied as necessary on a per-request basis.
This is the bare-bones approach to fixing #141 which I'm using in HTTPDownloads.jl (I had to vendor parts of Downloads to do that).
I can go ahead and add tests / docs if this seems like the right approach.
The thing I don't love about exposing the easy handle as part of the official API as it ties this package more closely with libcurl at an API level. Perhaps that's mostly solvable with documentation though + exposing more of the commonly needed operations so people don't need the escape hatch.
Codecov Report
Merging #148 (ba50864) into master (5f1509d) will increase coverage by
0.23%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 92.77% 93.00% +0.23%
==========================================
Files 5 5
Lines 498 515 +17
==========================================
+ Hits 462 479 +17
Misses 36 36
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/Downloads.jl | 83.00% <100.00%> (+0.17%) |
:arrow_up: |
| src/Curl/utils.jl | 97.67% <0.00%> (+0.11%) |
:arrow_up: |
| src/Curl/Easy.jl | 94.51% <0.00%> (+0.19%) |
:arrow_up: |
| src/Curl/Multi.jl | 96.06% <0.00%> (+0.19%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 5f1509d...ba50864. Read the comment docs.