VideoIO.jl icon indicating copy to clipboard operation
VideoIO.jl copied to clipboard

Fixing C-wrap errors (AVIndexEntry)

Open timholy opened this issue 7 years ago • 1 comments

I noticed that in AVIndexEntry, flags and size should be a bitfield union, and that our current struct (e.g., here) is therefore too large by one Cint. How would you like to fix this? Create patch files or directly edit the source?

timholy avatar Feb 04 '18 12:02 timholy

Just noting that this is still an issue here.

I never answered @timholy's original message (sorry!), but I think that editing the source and creating a patch file (this is how the patch files were created) is the right way. That way, when someone tries to rerun the wrap script, they should "just" be able to apply the patch to get the corrected value.

kmsquire avatar May 19 '19 19:05 kmsquire