JLD.jl icon indicating copy to clipboard operation
JLD.jl copied to clipboard

@write does not work unless HDF5 is importined in main

Open oxinabox opened this issue 10 years ago • 2 comments
trafficstars

All the documentations gives examples of usine @write file A etc. And says that it is no longer generally required to first import HDF5.

But using @write without fist using HDF5 will throw an error as the macro is not defined.

Should be an easy fix to add @write to the things being imported. (Next to the function write)

oxinabox avatar Nov 13 '15 06:11 oxinabox

As easy as <edit code>, git commit, and Pkg.submit("JLD") I'd say :wink:. Can you do that?

timholy avatar Nov 13 '15 09:11 timholy

Yeah, no worries. Though you missed the forking, pull request, and writing tests. (Or moving the using HDF5 down the test script so stuff that doesn't depend on it explicitly can be test without it.

oxinabox avatar Nov 13 '15 09:11 oxinabox