GraphIO.jl icon indicating copy to clipboard operation
GraphIO.jl copied to clipboard

feature request: newick format

Open mkborregaard opened this issue 7 years ago • 5 comments

Do you, or would you, support reading graphs specified in a Newick format? https://en.wikipedia.org/wiki/Newick_format ? Perhaps in the context of MetaGraphs (as the Newick format contains some metadata)?

mkborregaard avatar Sep 11 '18 22:09 mkborregaard

We don't currently have this, but it looks interesting if you'd like to give it a shot. My advice is to create it as a standalone package - we're currently rethinking how we provide different file formats for graphs, and the current idea is to have several packages in a single repo (now that we can do this in Pkg3).

sbromberger avatar Sep 12 '18 03:09 sbromberger

Oh 😞 Yeah I think having a standalone package just for a Newick parser is going rather overboard on the whole package-splitting thing. Especially given that you already have a dedicated GraphIO package :joy:

I'll probably just put it in my downstream package that uses (/will most likely switch to using) MetaGraphs instead. There are already a number of packages with Newick parsers in them.

I just felt that, when using MetaGraphs, this functionality might nest nicely in the graph ecosystem.

mkborregaard avatar Sep 12 '18 06:09 mkborregaard

If you import loadgraph, loadgraphs and savegraph from LightGraphs and implement them for the Newick format, it should be easy to add this to the LightGraphs ecosystem later.

simonschoelly avatar Sep 12 '18 09:09 simonschoelly

To be clear - the idea is to get rid of graphio as a package entirely and have each format be its own package but in a monorepo. That way, for example, if you need Graph6 you don’t need to have JLD installed.

sbromberger avatar Sep 12 '18 12:09 sbromberger

Hm OK - I'll have a look at the approach suggest by @simonschoelly

mkborregaard avatar Sep 12 '18 12:09 mkborregaard