MapTiles.jl icon indicating copy to clipboard operation
MapTiles.jl copied to clipboard

Refactor into MapTilesBase.jl

Open asinghvi17 opened this issue 7 months ago • 4 comments

Since the name is so natural it would be nice to have MapTiles.jl be a toplevel package that includes Downloads.jl/HTTP.jl, TileProviders.jl and some future VectorTiles.jl to be a toplevel package, and then include some of the downloading / caching functionality from Tyler.jl there.

Then we can have the base functionality that is currently in MapTiles hosted in MapTilesBase.jl. I don't mind making it a monorepo and potentially even stuffing TileProviders.jl in there as well.

What do you think?

@visr @evetion @rafaqz

asinghvi17 avatar Apr 13 '25 14:04 asinghvi17

Is there a concrete problem with putting Downloads.jl, HTTP.jl and TileProviders.jl dependencies directly in MapTiles.jl without adding MapTilesBase.jl?

I don't think it has any dependents that don't use those packages anyway, but maybe there is some reason I'm not aware of.

rafaqz avatar Apr 13 '25 14:04 rafaqz

MapTilesBase would then be an interface that PyramidScheme etc can use

Maybe it should be MapTilesInterface then

asinghvi17 avatar Apr 13 '25 14:04 asinghvi17

Makes sense,in that case I'm happy with either Base or Interface

rafaqz avatar Apr 13 '25 14:04 rafaqz

Yeah sounds like a good plan. Having them together in a monorepo is probably a bit easier to handle.

visr avatar Apr 13 '25 16:04 visr