LibGEOS.jl icon indicating copy to clipboard operation
LibGEOS.jl copied to clipboard

GeoInterface cleanup needed

Open rafaqz opened this issue 1 year ago • 2 comments

I noticed a bunch of weird stuff in the geo_interface.jl file during other PRs, like: https://github.com/JuliaGeo/LibGEOS.jl/blob/1c12df5f0677f2efd1def7b4ecb8ebd9bcaad40f/src/geo_interface.jl#L59 https://github.com/JuliaGeo/LibGEOS.jl/blob/1c12df5f0677f2efd1def7b4ecb8ebd9bcaad40f/src/geo_interface.jl#L49 https://github.com/JuliaGeo/LibGEOS.jl/blob/1c12df5f0677f2efd1def7b4ecb8ebd9bcaad40f/src/geo_interface.jl#L62

It could also do with some organization and comments

rafaqz avatar Jan 01 '24 21:01 rafaqz

Agreed. The zero seems like a wrong copy. The other two might be required for Aqua? Good to test though.

evetion avatar Jan 02 '24 06:01 evetion

I wondered that too, they at least need "ambiguity" comments if so

rafaqz avatar Jan 02 '24 10:01 rafaqz