GeoInterface.jl icon indicating copy to clipboard operation
GeoInterface.jl copied to clipboard

Remove ambiguity and implement `getgeom`, `ngeom` for `Wrappers.Point`

Open asinghvi17 opened this issue 1 year ago • 2 comments

This was mentioned on Slack, the output is probably a bit better than a method ambiguity error now.

asinghvi17 avatar Oct 23 '24 22:10 asinghvi17

Not sure nothing is the best return value here.

We could also just return the point from getgeom and ngeom could be 1

Or error

rafaqz avatar Oct 24 '24 13:10 rafaqz

Error might be best?

asinghvi17 avatar Oct 24 '24 14:10 asinghvi17

Error is pretty safe as we can always change it later, but returning nothing is permanent

rafaqz avatar Oct 31 '24 23:10 rafaqz

Maybe GI.getgeom(point, 1) should return the point? a bit like how numbers work just returning themselves?

Then GI.ngeom(point) should return 1

rafaqz avatar Dec 13 '24 22:12 rafaqz

Eh that sounds too recursive for my liking...let's just error

asinghvi17 avatar Sep 09 '25 09:09 asinghvi17

Where is this one at?

rafaqz avatar Nov 08 '25 06:11 rafaqz