KernelAbstractions.jl icon indicating copy to clipboard operation
KernelAbstractions.jl copied to clipboard

Add back support for force-inlining

Open vchuravy opened this issue 3 years ago • 7 comments

https://github.com/JuliaGPU/GPUCompiler.jl/pull/335

cc: @matinraayai @lcw

vchuravy avatar Jun 29 '22 18:06 vchuravy

That would be great. I tried to add it to CUDA.jl and it is not working yet. See https://github.com/JuliaGPU/CUDA.jl/pull/1554 for details.

lcw avatar Jun 29 '22 20:06 lcw

Thinking about this today, we have three options:

  1. Add it as a parameter to kernel construction
  2. Add it as a paramater to kernel launch
  3. Turn it on by default

vchuravy avatar Sep 23 '22 09:09 vchuravy

@vchuravy I think adding it as a parameter to kernel construction is a good idea.

matinraayai avatar Sep 26 '22 14:09 matinraayai

@matinraayai would you be interested in trying to add that?

vchuravy avatar Sep 26 '22 15:09 vchuravy

@vchuravy sure. How do I proceed?

matinraayai avatar Sep 26 '22 17:09 matinraayai

@lcw it seems that your PR for adding force-inlining support has been merged. If so can we close this issue?

matinraayai avatar Dec 15 '22 21:12 matinraayai

I think we still need to add forced inlining to the other GPU backends and then add a kernel construction parameter to kernel abstractions.

lcw avatar Dec 16 '22 00:12 lcw

Okay I'll investigate GCN.

matinraayai avatar Dec 17 '22 17:12 matinraayai