ForwardDiff.jl
ForwardDiff.jl copied to clipboard
Release 1.0
Noone wants to change FowardDIff. It is stable. Even if one does want to change ForwardDiff, noone wants to change the API in a breaking way.
I'd say we do https://github.com/JuliaDiff/ForwardDiff.jl/pull/419 and https://github.com/JuliaDiff/ForwardDiff.jl/pull/463, which I don't think are actually breaking changes, but can be considered breaking changes, and we can call that v1.0. Then, once it's v1.0, I'd say we can document the Dual number interface, https://github.com/JuliaDiff/ForwardDiff.jl/pull/379 because I'd hope no one would ever change that.
I'd like to get @KristofferC and @jrevels 's input though. But I think it's pretty safe to say, ForwardDiff works and if you want a very different AD then make a new package.
I agree with those 2 PRs.
Codecov Report
Merging #467 into master will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #467 +/- ##
=======================================
Coverage 87.31% 87.31%
=======================================
Files 10 10
Lines 757 757
=======================================
Hits 661 661
Misses 96 96
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update c4487d5...b8265b8. Read the comment docs.
Please don't make a non-breaking 1.0.0 release.
Its an unfortunate concisquence of julia's semver extension that 1.0.0 is always considered breaking. So if one realises a package that is pre-1.0.0 is actually stable one has to delcare a breaking release to indicated that there will not be many breaking releases in the future.
But in this case I am kind of happy to have it considered breaking because #463 is borderline breaking. Probabably fine for most uses, but I do know that sometimes people do construct duals directly, for better or worse.
Something holding this?
If someone wants to do this they need to make a corresponding change to the registry that allows ForwardDiff 1.0 for those packages that are currently claiming compatibility with ForwardDiff 0.10.
1.0 has already been tagged.
I don't know how to read.