FiniteDifferences.jl icon indicating copy to clipboard operation
FiniteDifferences.jl copied to clipboard

Decrease allocations

Open oxinabox opened this issue 5 years ago • 2 comments

Turns out type-stability was causing a bunch of allocations. Type inference was failing for some reason.

Also tracking history surpisingly, causes allocations. We don't need to track history when doing grad anyway.

This is built ontop of #59 and that should be merged first.

using BenchmarkTools
using FiniteDifferences

const _fdm = central_fdm(2,1);
const _fdm5 = central_fdm(5,1);

const xs = collect(1:0.1:200);
f(x) = sum(sin, x);
@btime grad($_fdm, $f, $xs);
@btime grad($_fdm5, $f, $xs);

This PR decreases allocation count by >60% and decreases allocation amoun t by >30%.

But that does not translate directly into speed. I guess it won't pay off much til the garbage collector gets avoided...

Current (oxmut1)

julia> @btime grad($_fdm, $f, $xs);
  202.552 ms (154789 allocations: 4.26 MiB)

julia> @btime grad($_fdm5, $f, $xs);
  413.311 ms (162753 allocations: 5.45 MiB)

New with Stability improvements

julia> @btime grad($_fdm, $f, $xs);
  200.205 ms (49777 allocations: 2.66 MiB)

julia> @btime grad($_fdm5, $f, $xs);
  398.832 ms (59732 allocations: 3.87 MiB)

oxinabox avatar Feb 02 '20 22:02 oxinabox

@oxinabox what's the status of this PR?

willtebbutt avatar Apr 09 '20 15:04 willtebbutt

Current status is the test failures need debugging and fixing

oxinabox avatar Apr 09 '20 18:04 oxinabox