Diffractor.jl
Diffractor.jl copied to clipboard
JuliaDiff
Cutting a release
Even though Diffractor isn't yet feature complete, it can already be a major improvement over Zygote for real-world use cases.
Yeah !!!!!!!!!!
On Sat, Jan 8, 2022 at 4:55 PM Brian Chen @.***> wrote:
Even though Diffractor isn't yet feature complete, it can already be a major improvement https://github.com/FluxML/Flux.jl/pull/1809#discussion_r777770025 over Zygote for real-world use cases.
— Reply to this email directly, view it on GitHub https://github.com/JuliaDiff/Diffractor.jl/issues/66, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI5LYDXALSQZY6V5AKRGRDUVCXEVANCNFSM5LRCB73A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
Just to be clear, this is a question to the maintainers and not an announcement or guarantee of anything :)
Right :-)
On Sat, Jan 8, 2022 at 5:52 PM Brian Chen @.***> wrote:
Just to be clear, this is a question to the maintainers and not an announcement or guarantee of anything :)
— Reply to this email directly, view it on GitHub https://github.com/JuliaDiff/Diffractor.jl/issues/66#issuecomment-1008171012, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI5LYDFMXCAOO2R55BQNRDUVC54TANCNFSM5LRCB73A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>
we should cut a 0.1.0 release. So that not all changes are breaking.
Probably should do so as soon as CI is not failing?
Not blocking, but should we make some effort to start organising a larger set of tests for this package?
Zygote's tests contain a lot of knowledge about potentially awkward edge cases, and it's possible that we should trawl through them and capture that. While hopefully leaving behind some of the very repetitive bits, or things which seem well captured by ChainRules's tests.
It has few second derivative tests, and maybe no forward mode tests, but the same awkward cases should ideally work for all of these. Perhaps we should structure things to make that easy, even if many fail right now.
I think copying a lot of Zygote's tests would be a good idea, and just mark them broken if they don't work. That's something anyone interested in Diffractor can help with.
