Diffractor.jl icon indicating copy to clipboard operation
Diffractor.jl copied to clipboard

Handle tuples with types in them

Open oxinabox opened this issue 2 years ago • 3 comments

Diffractor was having a bit of a sad because (Int,) has type Tuple{DataType} but the primal B has type Tuple{Type{Int}}, and while they are logically the same apparently dispatch does not like that.

The solution right now in this PR is to throw away that extra info we have about B and normalize it to just Typle{DataType}. idk if it is best, I am open to other ideas.

oxinabox avatar Oct 17 '23 08:10 oxinabox

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (7be0a92) 56.17% compared to head (2a9a3f7) 56.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   56.17%   56.19%   +0.01%     
==========================================
  Files          28       28              
  Lines        2848     2849       +1     
==========================================
+ Hits         1600     1601       +1     
  Misses       1248     1248              
Files Coverage Δ
src/stage1/recurse_fwd.jl 94.91% <100.00%> (+0.08%) :arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 17 '23 08:10 codecov[bot]

@Keno could you give this a review, and see if you think of a better way?

oxinabox avatar Nov 03 '23 08:11 oxinabox

@Keno review please

staticfloat avatar Jan 03 '24 03:01 staticfloat