Diffractor.jl icon indicating copy to clipboard operation
Diffractor.jl copied to clipboard

Fearless taylor version

Open oscardssmith opened this issue 2 years ago • 2 comments

If we're willing to use the information that derivatives are linear operators, we can remove a lot of complexity from forward mode differentiation (and improve type stability in the process). I know @Keno doesn't believe this is valid to assume, but IMO the simplification enabled provides a pretty strong justification that this is the right approach.

oscardssmith avatar Feb 11 '23 21:02 oscardssmith

in that case we definitely need test cases that break the assumption that everything is taylor because locally all the tests pass with this PR. (also, can you decipher the error message on CI I'm not able to understand or reproduce it).

oscardssmith avatar Feb 11 '23 21:02 oscardssmith

Codecov Report

Base: 50.87% // Head: 50.77% // Decreases project coverage by -0.10% :warning:

Coverage data is based on head (9b56ede) compared to base (0241872). Patch coverage: 55.26% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   50.87%   50.77%   -0.10%     
==========================================
  Files          27       27              
  Lines        2632     2572      -60     
==========================================
- Hits         1339     1306      -33     
+ Misses       1293     1266      -27     
Impacted Files Coverage Δ
src/codegen/forward_demand.jl 29.29% <0.00%> (-1.56%) :arrow_down:
src/stage1/mixed.jl 0.00% <0.00%> (ø)
src/stage1/recurse_fwd.jl 86.84% <0.00%> (-2.64%) :arrow_down:
src/jet.jl 41.02% <46.66%> (+1.35%) :arrow_up:
src/tangent.jl 25.75% <55.55%> (+1.22%) :arrow_up:
src/extra_rules.jl 41.81% <60.00%> (-2.73%) :arrow_down:
src/stage1/forward.jl 70.96% <71.42%> (+0.96%) :arrow_up:
src/stage1/recurse.jl 96.27% <75.00%> (-0.47%) :arrow_down:
src/interface.jl 67.92% <80.00%> (-1.17%) :arrow_down:
src/stage1/generated.jl 71.49% <93.75%> (-1.44%) :arrow_down:
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Feb 14 '23 17:02 codecov-commenter