ChainRulesCore.jl icon indicating copy to clipboard operation
ChainRulesCore.jl copied to clipboard

WIP: add whitespace check

Open simeonschaub opened this issue 4 years ago • 4 comments

simeonschaub avatar Sep 21 '21 21:09 simeonschaub

Codecov Report

Merging #463 (9fd609c) into master (bdb52bb) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 9fd609c differs from pull request most recent head 066711e. Consider uploading reports for the commit 066711e to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #463   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files          14       14           
  Lines         812      812           
=======================================
  Hits          755      755           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bdb52bb...066711e. Read the comment docs.

codecov-commenter avatar Sep 21 '21 21:09 codecov-commenter

Rather than a check which can fail, can we use the reviewdog action to insert a review suggestion for how to fix? That way do not have to change from the screen where it fails back the my editor.

oxinabox avatar Sep 21 '21 21:09 oxinabox

I'll look into that, once I figured out the other issues.

simeonschaub avatar Sep 21 '21 21:09 simeonschaub

@simeonschaub: in case you hadn't spotted it in the related issue yet, https://github.com/JuliaDiff/ChainRulesCore.jl/issues/462#issuecomment-925593793

st-- avatar Oct 06 '21 12:10 st--