ChainRules.jl icon indicating copy to clipboard operation
ChainRules.jl copied to clipboard

Fix `getindex` rule with AxisArrays (but break existing tests?)

Open devmotion opened this issue 1 year ago • 1 comments

This PR tries the suggestion in https://github.com/JuliaDiff/ChainRules.jl/pull/779#discussion_r1483664720 which apparently breaks some existing tests. I wonder what exactly is broken by these changes since the two-arg similar is quite standard and even recommended in the Julia docs: https://docs.julialang.org/en/v1/manual/methods/#Building-a-similar-type-with-a-different-type-parameter

devmotion avatar Feb 08 '24 22:02 devmotion

So it is only that one test I also saw break (I did not wait for all tests to finish running), though there may be more things breaking that aren't tested. Do you think this PR is worth pursuing further?

simsurace avatar Feb 10 '24 07:02 simsurace