ChainRules.jl icon indicating copy to clipboard operation
ChainRules.jl copied to clipboard

Add Emoji to GHA names

Open oxinabox opened this issue 4 years ago • 5 comments

Trying this out to see if it makes it easier to distinguish the different jobs

oxinabox avatar Jan 13 '21 22:01 oxinabox

Codecov Report

Merging #346 (2324c78) into master (f540c44) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          18       18           
  Lines        1147     1147           
=======================================
  Hits         1121     1121           
  Misses         26       26           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f540c44...2324c78. Read the comment docs.

codecov-io avatar Jan 13 '21 22:01 codecov-io

TBH I don't particularly like the choice of emojis (is that an old woman? Is that a night-time cityscape?). We want some visual way to tell them apart, but isn't what we really want some way to tell the things that must pass apart from the things that don't need to? Perhaps then it would be better to put some green emoji in the name of the CI workflows and other colors next to other workflows? Then for a quick visual check you look for red next to green, and that's a bad thing.

sethaxen avatar Jan 13 '21 22:01 sethaxen

Then for a quick visual check you look for red next to green, and that's a bad thing.

That's going to mess me up, I am going to spot any green and think that that line passes.

Is that an old woman? The emoji name is old person, I am not sure if person always defaults to man or woman, or androgenous. I wanted to indicate it is the oldest version of julia I will try and find another one for that

Is that a night-time cityscape? For nightly. I will try a sliver of a moon?

oxinabox avatar Jan 14 '21 13:01 oxinabox

i agree with Seth in that i find this more confusing.

can we just change to e.g. a star for things that are important (must pass), and no emoji for anything else?

nickrobinson251 avatar Jan 14 '21 17:01 nickrobinson251

Main thing was in my last PR (#342) I really wanted to quickly see if it was Julia 1.0 failing or Julia 1.5. I wonder if the answer is we should stop testing so many varients and operating systems. because having all those different ones made identifying which was failing harder

Side problem is IntegrationTestZygote must pass, unless Zygote is broken or not compatible.

oxinabox avatar Jan 14 '21 18:01 oxinabox