ChainRules.jl icon indicating copy to clipboard operation
ChainRules.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaDiff

Support for svdvals

Open MikeInnes opened this issue 5 years ago • 1 comments

We already have support for this via svd(X).S, but support for svdvals directly would be nice. It'd also be great to support GenericLinearAlgebra, which I don't think we do at the moment.

MikeInnes avatar Jun 10 '20 14:06 MikeInnes

GenericLinearAlgebra

The intent is that ChainRules.jl does not add rules for packages into ChainRules itself. Those rules belong in the packages themselves. Packages depend on ChainRulesCore for that.

We have an exception right now for SpecialFunctions and NaNMath, just because they were in DiffRules, though we plan to move them out eventually.

This is not the issue to talk about that as a matter of policy in though.

we should add svdvals support yes, PRs welcome.

oxinabox avatar Jun 10 '20 17:06 oxinabox