InferOpt.jl icon indicating copy to clipboard operation
InferOpt.jl copied to clipboard

No agnostic line search

Open gdalle opened this issue 2 years ago • 8 comments

Testing the waters to see if #40 has been solved by the latest release of FrankWolfe mentioned in https://github.com/ZIB-IOL/FrankWolfe.jl/issues/387

gdalle avatar Sep 20 '23 09:09 gdalle

@matbesancon this still errors

gdalle avatar Sep 20 '23 10:09 gdalle

Codecov Report

Patch coverage has no change and project coverage change: -0.26% :warning:

Comparison is base (0493719) 89.78% compared to head (fc9992e) 89.52%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   89.78%   89.52%   -0.26%     
==========================================
  Files          24       23       -1     
  Lines         695      678      -17     
==========================================
- Hits          624      607      -17     
  Misses         71       71              

see 5 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 20 '23 10:09 codecov-commenter

Ah my bad I hadn't released the better error printing in case of NaNs. But this will improve the error message only, the underlying problem here seems to be with NaN elements in the gradient no?

matbesancon avatar Sep 20 '23 11:09 matbesancon

It's interesting that it works on 1.7 though

gdalle avatar Sep 20 '23 11:09 gdalle

maybe you are not reaching the point where the gradient evaluates to NaN? The RNG in Julia changed from 1.7 onwards if I recall

matbesancon avatar Sep 20 '23 11:09 matbesancon

Possibly. Not sure how to debug this though, the MWE is pretty involved

gdalle avatar Sep 23 '23 08:09 gdalle

one ugly way would be to print the gradient at every iteration, or print the direction in the LMO itself

matbesancon avatar Sep 29 '23 12:09 matbesancon

let's debug that between main dish and dessert next week

matbesancon avatar Sep 29 '23 12:09 matbesancon

Fixed in #116.

BatyLeo avatar Dec 23 '24 15:12 BatyLeo