don't step over breakpoint on first statement

[pfitzseb]

Fixes https://github.com/JuliaDebug/Debugger.jl/issues/134.

[codecov-io]

Codecov Report

Merging #148 into master will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   80.59%   80.63%   +0.04%     
==========================================
  Files           7        7              
  Lines         474      475       +1     
==========================================
+ Hits          382      383       +1     
  Misses         92       92

Impacted Files	Coverage Δ
src/repl.jl	77.04% <100%> (ø)	:arrow_up:
src/Debugger.jl	91.3% <100%> (+0.39%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8720a9...23c0964. Read the comment docs.

[KristofferC]

Will this work even if we step through a wrapper function with a breakpoint?

[pfitzseb]

You mean for something like

julia> f(x; y=3) = x+y
f (generic function with 1 method)

julia> @breakpoint f(2, y=3)
breakpoint((::getfield(Main, Symbol("#kw##f")))(::Any, ::typeof(f), x) in Main, line 0)

julia> @run f(2,y=3)
5

? No. We could use

    quote
        theargs = $(esc(args))
        frame = JuliaInterpreter.enter_call_expr(Expr(:call,theargs...))
        if frame ≠ nothing && !JuliaInterpreter.shouldbreak(frame, frame.pc)
            frame = JuliaInterpreter.maybe_step_through_kwprep!(frame)
            if frame ≠ nothing && !JuliaInterpreter.shouldbreak(frame, frame.pc)
                frame = JuliaInterpreter.maybe_step_through_wrapper!(frame)
                if frame ≠ nothing && !JuliaInterpreter.shouldbreak(frame, frame.pc)
                    JuliaInterpreter.maybe_next_call!(frame)
                end
            end
        end
        frame
    end

for that to work though, although I'd kinda argue that the breakpoint shouldn't be set in the wrapper at all. Alternatively we could maybe handle this on the JuliaInterpreter side somewhat like this.