adjustments to JuliaLang/julia#52415

[aviatesk]

trafficstars

/cc @vtjnash

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (9ba8bfc) to head (c32ead7).

Files	Patch %	Lines
src/codeview.jl	0.00%	4 Missing :warning:
src/interpreter.jl	0.00%	1 Missing :warning:

Additional details and impacted files

@@          Coverage Diff           @@
##           master    #558   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           9       9           
  Lines        1541    1544    +3     
======================================
- Misses       1541    1544    +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[aviatesk]

This PR leverages the new type printing feature from #52415:

[vtjnash]

Seems to be a less complete version of https://github.com/JuliaDebug/Cthulhu.jl/pull/526? That was currently blocked on getting my PRs for JuliaInterpreter merged so it works on Julia v1.11+ again

I am excited to see the new type printing feature getting used, but I am skeptical that other folks will want to have doubled (or more) the number of contextual lines that get printed by default. It might need to be opt-in in some way?

[aviatesk]

Oops, I didn't notice you'd already put in a PR. My bad. ~~Anyway, why should we prioritize merging JuliaInterpreter? Since Cthulhu doesn't rely on JuliaInterpreter, we could update it on its own, right? It sounds like updating JuliaInterpreter might take a bit while.~~ Ok, our test cases definitely depend on Revise..

[aviatesk]

Regarding the extra debug information, I believe it should be okay because :source-mode is already an opt-in feature.

[vtjnash]

I thought this relied on it. But maybe that was Revise instead that relies on it?