PostgreSQL.jl
PostgreSQL.jl copied to clipboard
[WIP] Get tests passing on Julia v0.4-v0.6
Will require https://github.com/JuliaDB/DBI.jl/pull/16 to be merged to get tests passing on v0.6. Probably worth registering DBI and tagging a version. Intended to eventually fix #52 and will close #51
Coverage decreased (-63.9%) to 11.628% when pulling 2ec6e623b5ae4fc1a0f8a2baacb667b569767a60 on jgoldfar:get-tests-passing-v0.4-v0.6 into a29b45f9d922948dc914d4cc3e34a7352fa29282 on JuliaDB:master.
By the way, I've thought about the discussion in https://github.com/JuliaDB/PostgreSQL.jl/pull/48#discussion_r89632468 which I believe this will also suffer from (one of the reasons for the WIP tag) but the referenced functionality does not seem to be tested anywhere, so making sure an implementation is working would be tricky. Is there a test case?
A good test case: make a string type that doesn't rely on an array of bytes and call pgdata with that.
Codecov Report
Merging #53 into master will decrease coverage by
63.93%. The diff coverage is7.14%.
@@ Coverage Diff @@
## master #53 +/- ##
===========================================
- Coverage 75.56% 11.62% -63.94%
===========================================
Files 3 3
Lines 221 215 -6
===========================================
- Hits 167 25 -142
- Misses 54 190 +136
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/types.jl | 7.14% <ø> (-63.13%) |
:arrow_down: |
| src/dbi_impl.jl | 11.97% <0%> (-65.81%) |
:arrow_down: |
| src/libpq_common.jl | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a29b45f...c5744a9. Read the comment docs.