YAXArrays.jl icon indicating copy to clipboard operation
YAXArrays.jl copied to clipboard

Inconsistency in syntax between `savecube` and `savedataset`

Open Qfl3x opened this issue 2 years ago • 2 comments

Why is the path savecube a "normal" argument, while path in savedataset a kwarg?

Qfl3x avatar Oct 18 '23 10:10 Qfl3x

Indeed. Things should be unified. There is an open issue about it as well: https://github.com/JuliaDataCubes/YAXArrays.jl/issues/309. Some work needs to be done also here.

lazarusA avatar Oct 18 '23 10:10 lazarusA

Another thing is that path isn't a mandatory kwarg, and it has a default value of "", wouldn't that create unexpected behavior?

Qfl3x avatar Oct 19 '23 07:10 Qfl3x