TableView.jl icon indicating copy to clipboard operation
TableView.jl copied to clipboard

Incorrect Table Height when Displaying in REPL (w/ Blink)

Open jacobadenbaum opened this issue 6 years ago • 2 comments

When displaying the table in the REPL using blink (as suggested in the README), the table doesn't scale to fit the window, which can be annoying if you want to resize it/move it around, etc...

It looks like this is because the default behavior is to set the height to a fixed number. I think this can be fixed by setting height = "100vh" (see this answer on stack overflow).

Should this (or something like it) be the default?

jacobadenbaum avatar Mar 06 '19 20:03 jacobadenbaum

No, this unfortunately can't be the default behaviour because it breaks in other contexts (e.g. Jupyter).

I guess we could try to make the defaults context sensitive (i.e. try to figure out where we're being run and set the defaults accordingly), but imho that's the wrong solution. There probably is a clean solution to this, but a) not with the current WebIO and b) I can't figure it out.

pfitzseb avatar Mar 07 '19 09:03 pfitzseb

Yeah, I figured it must be something like that. I would up wrapping the correct solution that makes a blink window and populates it output that has autoscaling height in a little 10 line package in case anyone else is annoyed by this.

jacobadenbaum avatar Mar 07 '19 15:03 jacobadenbaum