DataStructures.jl icon indicating copy to clipboard operation
DataStructures.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaCollections

Rename DisjointSets to DisjointSet ?

Open oxinabox opened this issue 5 years ago • 4 comments
trafficstars

The fact that DisjointSets is a collection of sets under the hood is not relevent to the user. The API is that of a AbstractSet. The implementation is a implementation detail that is actually completely invisible to the user AFAICT

oxinabox avatar Feb 10 '20 11:02 oxinabox

@c-p-murphy did you ever make a PR to do this? I can't find it

oxinabox avatar Jun 03 '20 20:06 oxinabox

Hey @oxinabox—no, sorry, things got hectic this past semester with everything going on in the world and I lost track of it. I'll try to finish putting something together over the next week or so and then submit a PR. Thanks for the reminder.

c-p-murphy avatar Jun 03 '20 21:06 c-p-murphy

Cool I might hold off releasing 0.18 for this so can get the deprecations in. cf #577

oxinabox avatar Jun 03 '20 23:06 oxinabox

@c-p-murphy any update? I wouls still like to get this in before tagging 0.18

oxinabox avatar Jun 24 '20 09:06 oxinabox

Already fixed by https://github.com/JuliaCollections/DataStructures.jl/pull/700

laborg avatar Oct 04 '23 18:10 laborg