PkgTemplates.jl icon indicating copy to clipboard operation
PkgTemplates.jl copied to clipboard

Use `Path` type for paths, not `String`s?

Open nickrobinson251 opened this issue 6 years ago • 3 comments
trafficstars

I noticed #61 still uses Strings for filepaths, but we could instead use https://github.com/rofinn/FilePathsBase.jl

nickrobinson251 avatar Oct 04 '19 00:10 nickrobinson251

Yeah I thought about it very briefly but didn't look into it too hard. Provided that it doesn't affect the user API, I'm good with it.

christopher-dG avatar Oct 04 '19 00:10 christopher-dG

agreed, we shouldn't affect public API; the suggestion is use it behind the scenes to hopefully make maintainence easier :)

nickrobinson251 avatar Oct 04 '19 00:10 nickrobinson251

I am going to leave FilePaths out for now, it can almost definitely be added later though.

christopher-dG avatar Oct 05 '19 14:10 christopher-dG