StaticArrays.jl icon indicating copy to clipboard operation
StaticArrays.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaArrays

export SUnitRange

Open schmrlng opened this issue 7 years ago • 8 comments

I feel like SUnitRange is useful enough (especially for slicing other StaticArrays) to merit exporting.

schmrlng avatar Aug 10 '18 02:08 schmrlng

Yes, this isn't unreasonable... :)

There has been a long-standing plan to support static ranges, LinearIndices and CartesianIndices with StaticArrays. These things would be returned by axes and indices. I've been waiting for v1.0 for that to happen (because compatibility is hard enough between v0.6 users and v1.0 users already) so it might be time to have a rethink of this soon.

andyferris avatar Aug 11 '18 06:08 andyferris

Sure, if it's a question of API stability/not committing to this exact form for fewer "breaking" changes once more general ranges are worked out I'm happy to keep manually importing this secret functionality.

schmrlng avatar Aug 11 '18 06:08 schmrlng

OK thanks. Please bump this again soon-ish if I don't get to this.

andyferris avatar Aug 11 '18 06:08 andyferris

This PR addresses #620. It would be nice to have a docstring though, perhaps with an example in use, and the docs should also mention this.

tpapp avatar Nov 02 '19 13:11 tpapp

Friendly bump --- could this be merged please?

tpapp avatar Feb 09 '20 16:02 tpapp

What's the status of this PR? Is this just waiting for resolving the conflicts?

hyrodium avatar Apr 21 '22 13:04 hyrodium

Friendly ping; please reconsider this PR. If anything else needs to be done I am willing to do it or make another PR if that is preferred.

tpapp avatar Dec 06 '23 15:12 tpapp

I think the only problem with SUnitRange is https://github.com/JuliaArrays/StaticArrays.jl/issues/978. It would be better to have SUnitRange <: AbstractUnitRange, but changing the supertype may be a breaking change because the type is widely used, I guess.

Considering SUnitRange as a stable API is not a bad practice, so exporting it would be okay for me.

hyrodium avatar Dec 07 '23 15:12 hyrodium