rusherhack-issues icon indicating copy to clipboard operation
rusherhack-issues copied to clipboard

[FEATURE] Notebot

Open Gentleman2292 opened this issue 4 years ago • 4 comments

add notebot and songstealer pls

Gentleman2292 avatar Feb 04 '21 07:02 Gentleman2292

Bump

ghost avatar Feb 05 '21 21:02 ghost

https://github.com/Victormeriqui/Notebot

outlineutils avatar Feb 06 '21 19:02 outlineutils

I plan on adding this but it will be very low priority.

John200410 avatar Feb 08 '21 23:02 John200410

Is this still on the back burner? Are there 3rd party mods that can provide 1.20.x notebot functionality that don't conflict with RusherHack?

A rusherhack plugin has now been created to add this functionality: https://github.com/Lokfid/RusherHackNoteBot

John200410 avatar Aug 13 '24 17:08 John200410

Has anyone tried if it works and is safe?

After enabling the plugin functionality with the java arguments I can see the plugin is loaded but the commands the plugin is supposed to add are not working or listed in *help. This also means I have to trust random plug-ins developers instead of Rusher developers and if it doesn't work like now then what? Open an issue on their Github page and ask for support? I had hoped for something native.

Screenshot 2024-09-02 at 11 39 41

Your NoteBot Plugin is not loaded its in red color. Maybe you are on the wrong version it should say in rusherhack console (~) also native support for plugins will be added in 2.1

Lokfid avatar Sep 02 '24 09:09 Lokfid

yeah, i need to add 1.20.4+ support im just pretty busy these days. Oh and my pleasure :-)

Lokfid avatar Sep 02 '24 09:09 Lokfid

Did a bunch of testing on 1.20.4 but no matter what .nbs file I try it crashes once it tries to play it. Not sure if it helps but I've attached the crash log and the test.nbs file used (Bad Apple from a Gtihub archive of nbs files). No mods other than Rusher are installed in this Prism instance. It doesn't seem to check if a file exists and there is no file name completion (yet).

[12:37:07] [Render thread/INFO]: Added test.nbs to the queue
[12:37:07] [Render thread/INFO]: [RusherHack] [CHAT] [rusherhack] Added test.nbs to the queue
[12:37:16] [Render thread/ERROR]: Reported exception thrown!

crash-2024-09-02_12.37.17-client.txt

test.nbs.zip

I'll wait for the official release of the plugin system and fixes to the plugin. No problem! Once both are officially released and if any problems occur I'll open an issue on your issue tracker instead of polluting this thread lol.

about crash that is a known problem and i will try to fix it asap checking if file exists is already made i just havent pushed it to github, and autocompletion is not possible until john will add it

Lokfid avatar Sep 02 '24 12:09 Lokfid

Has anyone tried if it works and is safe?

After enabling the plugin functionality with the java arguments I can see the plugin is loaded but the commands the plugin is supposed to add are not working or listed in *help. This also means I have to trust random plug-ins developers instead of Rusher developers and if it doesn't work like now then what? Open an issue on their Github page and ask for support? I had hoped for something native.

Screenshot 2024-09-02 at 11 39 41

Once the plugin system is finished in v2.1, there will be an in-game repository of verified plugins. For now the plugin system is still being beta tested

John200410 avatar Sep 02 '24 14:09 John200410