jaxrenderer fix error: jax_array config option is removed in jax v0.4.14

Reopened pull request, jax_array config option has been removed since jax commit 59509dc.

Sep 16 '23 05:09 chaihahaha

Thank you for updating this! Just a quick reply, I would need a little bit of time to unblock the CI to merge it. I'll update you when I am done:)

Sep 18 '23 14:09 JoeyTeng

@JoeyTeng Hello, I found a backward compatibility issue of the original modification and fixed it. Could you check this PR again?

Nov 02 '23 16:11 chaihahaha

@chaihahaha sorry to let you wait for so long. I will check soon to fix the CI. However, I see you are using dir(). It is not recommended to use that outside of interactive interpreter. Could you change that with hasattr()? I don't have other issues with your PR. I just need to fix the CI in order to merge your PR.

Nov 14 '23 09:11 JoeyTeng

Thanks for pointing it out, and thanks for your effort to maintain this repo.

I have fixed my RP with respect to your concern.

Nov 14 '23 11:11 chaihahaha

This pull request will close https://github.com/JoeyTeng/jaxrenderer/issues/18

Feb 02 '24 01:02 chaihahaha

Hi hi, do we have any updates on this? The use of deprecated jax_array option is blocking the Colab example from running as well, and it would be great if this PR can be merged :)

Apr 26 '24 01:04 horizon-blue

I can confirm, manually integrating the changes of this pull requests, makes the jaxrenderer functional again.

May 25 '24 09:05 markusheimerl